Fix bug with extract_data_from_json and jmespath int or float#160
Open
Fix bug with extract_data_from_json and jmespath int or float#160
Conversation
smk4664
requested review from
jeffkala,
lvrfrc87,
pszulczewski and
scetron
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #159
This PR ensures that we only try to iterate over a list when extracting data using the JMESPath. During my testing, I did notice that this was not always happening, depending on how I wrote the JMESPath, so it is possible that this may be unnecessary.
The following works:
data = [
{"metric": 1000, "threshold": .75}
]
path = "[].metric" or "[].threshold"